#66 [feat] 유저별 데일리루틴 리스트 조회 api 연결 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-halo
requested changes
Jan 16, 2024
| private val dailyRoutineDataSource: DailyRoutineDataSource | ||
| ) : DailyRoutineRepository { | ||
| override suspend fun getDailyRoutine(): Result<List<DailyRoutine>> = | ||
| runCatching { dailyRoutineDataSource.getDailyRoutine() }.mapCatching { response -> |
There was a problem hiding this comment.
mapCatching을 쓰셨군요! 👍
https://medium.com/harrythegreat/kotlin-runcatching%EA%B3%BC-result-%ED%83%80%EC%9E%85-ab261f47efa8
map과 mapCatching의 차이입니다~ 혹시나 하여 남기고 가요
| Timber.d("뷰모델 서버 성공") | ||
| } | ||
| .onFailure { throwable -> | ||
| Timber.d("뷰모델 서버 실패") |
…roid into feature/#66-daily-routine-user-api # Conflicts: # app/src/main/java/com/sopetit/softie/data/repositoryImpl/DailyRoutineRepositoryImpl.kt # app/src/main/java/com/sopetit/softie/data/service/DailyRoutineService.kt # app/src/main/java/com/sopetit/softie/data/source/DailyRoutineDataSource.kt # app/src/main/java/com/sopetit/softie/di/RepositoryModule.kt # app/src/main/java/com/sopetit/softie/di/RetrofitServiceModule.kt # app/src/main/java/com/sopetit/softie/domain/repository/DailyRoutineRepository.kt
emjayMJkim
approved these changes
Jan 17, 2024
| import javax.inject.Inject | ||
|
|
||
| class DeleteDailyRoutineUseCase @Inject constructor( | ||
| private val deleteDailyRoutine: DailyRoutineRepository |
There was a problem hiding this comment.
이 부분 변수 크게 상관은 없지만 dailyRoutineRespository 이런 식으로 repository를 받아온다는 걸 명확하게 하면 좀 더 좋을 것 같습니당
Comment on lines
99
to
107
| private fun achieveRoutine() { | ||
| viewModel.isRoutineAchieveFirst.observe(viewLifecycleOwner) { | ||
| } | ||
| viewModel.isRoutineAchieveSecond.observe(viewLifecycleOwner) { | ||
| } | ||
| viewModel.isRoutineAchieveThird.observe(viewLifecycleOwner) { | ||
| } | ||
| } | ||
|
|
pump9918
approved these changes
Jan 17, 2024
|
|
||
| override suspend fun postAddDailyRoutine(routineId: Int): Result<AddRoutine> = | ||
| runCatching { | ||
| dailyRoutineDataSource.postAddDailyRoutine(routineId) |
There was a problem hiding this comment.
it대신 response로 그 위치를 명시해주라는 리드님의 말씀을 잘 지켰네요!
stellar-halo
approved these changes
Jan 17, 2024
Comment on lines
+130
to
+134
| viewModel.isRoutineAchieveFirst.observe(viewLifecycleOwner) { | ||
| } | ||
| viewModel.isRoutineAchieveSecond.observe(viewLifecycleOwner) { | ||
| } | ||
| viewModel.isRoutineAchieveThird.observe(viewLifecycleOwner) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_recording_20240118_053912.mp4
💬 To Reviewers